Change Code-Review to use a submit-requirement
Make the Code-Review label no longer blocking. Then add a
submit-requirement that requires Code-Review+2, but is overridden by
(new label) Bot-Commit+1.
Change-Id: Ia00d01978540b062c3fe25f4189b0929847b6b8c
Reviewed-on: https://bluetooth-review.git.corp.google.com/c/All-Projects/+/1080
Reviewed-by: Ted Pudlik <tpudlik@google.com>
diff --git a/project.config b/project.config
index 525e05f..ddc45e7 100644
--- a/project.config
+++ b/project.config
@@ -57,7 +57,7 @@
createTag = group Administrators
createTag = group Project Owners
[label "Code-Review"]
- function = MaxWithBlock
+ function = NoBlock
defaultValue = 0
copyMinScore = true
copyAllScoresOnTrivialRebase = true
@@ -66,6 +66,11 @@
value = 0 No score
value = +1 Looks good to me, but someone else must approve
value = +2 Looks good to me, approved
+[label "Bot-Commit"]
+ defaultValue = 0
+ value = 0 No score
+ value = +1 Bot Commit
+ function = NoBlock
[accounts]
sameGroupVisibility = deny group google/google-union:signcla
[contributor-agreement "Google CLA"]
@@ -76,4 +81,9 @@
[capability]
administrateServer = group Administrators
[plugin "jwtservice"]
- audience = "https://api.cr.dev"
\ No newline at end of file
+ audience = "https://api.cr.dev"
+[submit-requirement "Code-Review"]
+ description = The Code-Review label is required.
+ submittableIf = -label:Code-Review=MIN AND label:Code-Review=MAX,user=non_uploader
+ overrideIf = label:Bot-Commit=MAX
+ canOverrideInChildProjects = true
